fix: Null function pointer dereference.

iphydf · iphydf · commit b8ce394e643d · 2022-02-22T01:55:15.000Z
diff --git a/toxcore/tox.c b/toxcore/tox.c
@@ -115,7 +115,10 @@ static void tox_log_handler(void *context, Logger_Level level, const char *file,
 {
     Tox *tox = (Tox *)context;
     assert(tox != nullptr);
-    tox->log_callback(tox, (Tox_Log_Level)level, file, line, func, message, userdata);
+
+    if (tox->log_callback != nullptr) {
+        tox->log_callback(tox, (Tox_Log_Level)level, file, line, func, message, userdata);
+    }
 }
 
 static m_self_connection_status_cb tox_self_connection_status_handler;

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,10 @@ static void tox_log_handler(void context, Logger_Level level, const char file,`
`115`	`115`	`{`
`116`	`116`	`Tox tox = (Tox )context;`
`117`	`117`	`assert(tox != nullptr);`
`118`		`- tox->log_callback(tox, (Tox_Log_Level)level, file, line, func, message, userdata);`
	`118`	`+`
	`119`	`+ if (tox->log_callback != nullptr) {`
	`120`	`+ tox->log_callback(tox, (Tox_Log_Level)level, file, line, func, message, userdata);`
	`121`	`+ }`
`119`	`122`	`}`
`120`	`123`
`121`	`124`	`static m_self_connection_status_cb tox_self_connection_status_handler;`