Sodium.h missing?

[almindor]

I'm getting

  CC       ../testing/misc_tools.lo
../testing/misc_tools.c:43:20: fatal error: sodium.h: No such file or directory
 #include "sodium.h"

when running make on v0.2.6 release. This is a regression that seems to have been introduced in v0.2.6 specifically commit fb89c03

I am using these configuration options:

 ./configure --with-pic --prefix "$FAKEDIR" --with-libsodium-headers="$SODIUMDIR/src/libsodium/include" --with-libsodium-libs="$SODIUMLIBSDIR"

The directories for sodium includes are all good and the same steps compile and build with 0.2.5

[nurupo]

Try changing #include "sodium.h" to #include <sodium.h>.

[almindor]

This is not about me getting it to build, this is to report a regression/bug. The include is in toxcore sources. I don't want to force a patch on each build.

[nurupo]

Alright, you don't want to test it. I will test it later when I get to a computer.

[zugz]

Thanks for the report. This will be fixed in the next release.

[almindor]

Oh sorry about that, the way you worded your reply I thought you meant I should just change it on my end. I'll test it to make sure it's the right fix.

[almindor]

Changing "sodium.h" to <sodium.h> doesn't seem to fix it. I wonder if it's missing the -I <path-to-libsodium-from-configure> setup for this file since this was added in.

[zugz]

* Monday, 2018-08-20 at 16:33 +0000 - Aleš Katona <notifications@github.com>:

Changing `"sodium.h"` to `<sodium.h>` doesn't seem to fix it. I wonder if it's missing the `-I <path-to-libsodium-from-configure>` setup for this file since this was added in.

I haven't managed to replicate, but this does make sense. Could you please check whether #1106 fixes the problem?

[zoff99]

@almindor autotools (configure) are not fully fixed yet. the default method is cmake.
autotools also do not yet make 1 lib only (you get more than 1 library file).
we will try to fix this within the next few releases ...

[almindor]

@zugz Your PR fixes the issue :) thanks

[almindor]

@zoff99 I see. I'm only interested in the static files. This is for the SailfishOS (mobile) build of jTox. I use a VM (sailfish SDK) with some cross-compile environment setup to build the static .a files which are then included in the project for static linking. If autotools is generally outdated I guess I can switch to cmake but the PR from @zugz works for me.

[zugz]

@zugz Your PR fixes the issue :) thanks

Great. Thanks for reporting and testing.

[almindor]

Seems this issue is fixed in the last release.