valgrind reports "Conditional jump or move depends on uninitialised value(s)"

[zugz]

Output of
valgrind --track-origins=yes --leak-check=full ./auto_tox_many_tcp_test
on commit 94451e59dc85dac2a231ff08fc23e587418a8abe (PR #1216, without which it
also reports memleaks):

==4065== Memcheck, a memory error detector
==4065== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==4065== Using Valgrind-3.10.0 and LibVEX; rerun with -h for copyright info
==4065== Command: auto_tox_many_tcp_test
==4065==
[#1] DEBUG network.c:836        new_networking_ex:      Dual-stack socket: enabled
[#1] DEBUG network.c:849        new_networking_ex:      Local multicast group FF02::1 joined successfully. (0, Success)
[#1] DEBUG network.c:881        new_networking_ex:      Bound successfully to [::]:33445
[#2] ERROR network.c:477        sendpacket:     attempted to send message of length 113 on uninitialised socket
[#3] ERROR network.c:477        sendpacket:     attempted to send message of length 113 on uninitialised socket
[#4] ERROR network.c:477        sendpacket:     attempted to send message of length 113 on uninitialised socket
[#5] ERROR network.c:477        sendpacket:     attempted to send message of length 113 on uninitialised socket
[#6] ERROR network.c:477        sendpacket:     attempted to send message of length 113 on uninitialised socket
[#7] ERROR network.c:477        sendpacket:     attempted to send message of length 113 on uninitialised socket
[#8] ERROR network.c:477        sendpacket:     attempted to send message of length 113 on uninitialised socket
[#9] ERROR network.c:477        sendpacket:     attempted to send message of length 113 on uninitialised socket
[#10] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#11] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#12] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#13] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#14] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#15] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#16] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#17] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#18] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#19] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#20] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#21] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#22] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#23] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#24] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#25] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#26] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#27] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#28] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#29] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#30] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#31] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#32] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#33] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#34] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#35] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#36] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#37] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#38] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#39] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
[#40] ERROR network.c:477       sendpacket:     attempted to send message of length 113 on uninitialised socket
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8055AA2: ipport_equal (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80650AC: is_path_used (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8065303: random_path (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8065984: client_send_announce_request (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80689AD: do_announce (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8068B7E: do_onion_client (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806E1E7: do_messenger (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80527C7: tox_iterate (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805057C: test_many_clients_tcp (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050BD5: tox_suite (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050C09: main (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8055AB5: ipport_equal (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80650AC: is_path_used (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8065303: random_path (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8065984: client_send_announce_request (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80689AD: do_announce (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8068B7E: do_onion_client (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806E1E7: do_messenger (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80527C7: tox_iterate (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805057C: test_many_clients_tcp (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050BD5: tox_suite (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050C09: main (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8055AA2: ipport_equal (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80650AC: is_path_used (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8065303: random_path (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80659B2: client_send_announce_request (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80682E0: do_friend (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8068CC9: do_onion_client (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806E1E7: do_messenger (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80527C7: tox_iterate (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805057C: test_many_clients_tcp (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050BD5: tox_suite (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050C09: main (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8055AB5: ipport_equal (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80650AC: is_path_used (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8065303: random_path (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80659B2: client_send_announce_request (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80682E0: do_friend (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8068CC9: do_onion_client (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806E1E7: do_messenger (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80527C7: tox_iterate (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805057C: test_many_clients_tcp (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050BD5: tox_suite (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050C09: main (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8055AA2: ipport_equal (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80650AC: is_path_used (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8065303: random_path (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80670AA: send_onion_data (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8067616: send_dhtpk_announce (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8068384: do_friend (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8068CC9: do_onion_client (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806E1E7: do_messenger (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80527C7: tox_iterate (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805057C: test_many_clients_tcp (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050BD5: tox_suite (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050C09: main (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8055AB5: ipport_equal (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80650AC: is_path_used (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8065303: random_path (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80670AA: send_onion_data (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8067616: send_dhtpk_announce (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8068384: do_friend (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8068CC9: do_onion_client (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806E1E7: do_messenger (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80527C7: tox_iterate (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805057C: test_many_clients_tcp (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050BD5: tox_suite (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050C09: main (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8056925: ipv6_ipv4_in_v6 (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805D6D2: ip_is_local (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D1D7: friend_add_tcp_relay (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D6CD: tcp_relay_node_callback (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8066DCA: handle_dhtpk_announce (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8066A10: handle_data_response (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8066E99: handle_tcp_onion (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8076DE7: tcp_onion_callback (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8080330: handle_TCP_client_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x808044A: tcp_process_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8080592: do_confirmed_TCP (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80807C9: do_TCP_connection (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x805D6FA: ip_is_local (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D1D7: friend_add_tcp_relay (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D6CD: tcp_relay_node_callback (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8066DCA: handle_dhtpk_announce (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8066A10: handle_data_response (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8066E99: handle_tcp_onion (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8076DE7: tcp_onion_callback (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8080330: handle_TCP_client_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x808044A: tcp_process_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8080592: do_confirmed_TCP (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80807C9: do_TCP_connection (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807771C: do_tcp_conns (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8056925: ipv6_ipv4_in_v6 (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805D6D2: ip_is_local (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D1D7: friend_add_tcp_relay (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D5BF: send_relays (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807EAF5: do_friend_connections (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806E1FC: do_messenger (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80527C7: tox_iterate (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805057C: test_many_clients_tcp (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050BD5: tox_suite (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050C09: main (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x805D6FA: ip_is_local (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D1D7: friend_add_tcp_relay (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D5BF: send_relays (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807EAF5: do_friend_connections (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806E1FC: do_messenger (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80527C7: tox_iterate (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805057C: test_many_clients_tcp (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050BD5: tox_suite (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8050C09: main (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x8056925: ipv6_ipv4_in_v6 (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x805D6D2: ip_is_local (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D1D7: friend_add_tcp_relay (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807DC9B: handle_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806162A: handle_data_packet_core (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8061A37: handle_packet_connection (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806287F: tcp_data_callback (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8076C9D: tcp_conn_data_callback (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80803B9: handle_TCP_client_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x808044A: tcp_process_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8080592: do_confirmed_TCP (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80807C9: do_TCP_connection (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065== Conditional jump or move depends on uninitialised value(s)
==4065==    at 0x805D6FA: ip_is_local (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807D1D7: friend_add_tcp_relay (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807DC9B: handle_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806162A: handle_data_packet_core (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8061A37: handle_packet_connection (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x806287F: tcp_data_callback (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8076C9D: tcp_conn_data_callback (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80803B9: handle_TCP_client_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x808044A: tcp_process_packet (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x8080592: do_confirmed_TCP (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x80807C9: do_TCP_connection (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==    by 0x807771C: do_tcp_conns (in /home/martin/src/hackings/c-toxcore/auto_tox_many_tcp_test)
==4065==
==4065==
==4065== HEAP SUMMARY:
==4065==     in use at exit: 53,417,064 bytes in 1,378 blocks
==4065==   total heap usage: 41,229 allocs, 39,851 frees, 67,896,496 bytes allocated
==4065==
==4065== LEAK SUMMARY:
==4065==    definitely lost: 0 bytes in 0 blocks
==4065==    indirectly lost: 0 bytes in 0 blocks
==4065==      possibly lost: 0 bytes in 0 blocks
==4065==    still reachable: 53,417,064 bytes in 1,378 blocks
==4065==         suppressed: 0 bytes in 0 blocks
==4065== Rerun with --leak-check=full to see details of leaked memory
==4065==
==4065== For counts of detected and suppressed errors, rerun with: -v
==4065== Use --track-origins=yes to see where uninitialised values come from
==4065== ERROR SUMMARY: 1437 errors from 12 contexts (suppressed: 0 from 0)

[zugz]

To clarify: the test didn't actually complete here (it seems never to when run with valgrind), but rather was killed, hence the "still reachable" memory.

[kpp]

That's where you could start from:

diff --git a/toxcore/onion_client.c b/toxcore/onion_client.c
index 1c3b34d..01c5439 100644
--- a/toxcore/onion_client.c
+++ b/toxcore/onion_client.c
@@ -377,7 +377,7 @@ static int random_path(const Onion_Client *onion_c, Onion_Client_Paths *onion_pa
     }
 
     if (path_timed_out(onion_c->mono_time, onion_paths, pathnum)) {
-        Node_format nodes[ONION_PATH_LENGTH];
+        Node_format nodes[ONION_PATH_LENGTH] = {};
 
         if (random_nodes_path_onion(onion_c, nodes, ONION_PATH_LENGTH) != ONION_PATH_LENGTH) {
             return -1;
@@ -984,7 +984,7 @@ static int handle_dhtpk_announce(void *object, const uint8_t *source_pubkey, con
     uint16_t len_nodes = length - DHTPK_DATA_MIN_LENGTH;
 
     if (len_nodes != 0) {
-        Node_format nodes[MAX_SENT_NODES];
+        Node_format nodes[MAX_SENT_NODES] = {};
         int num_nodes = unpack_nodes(nodes, MAX_SENT_NODES, nullptr, data + 1 + sizeof(uint64_t) + CRYPTO_PUBLIC_KEY_SIZE,
                                      len_nodes, 1);

[iphydf]

@kpp that's probably the wrong fix, since it means we're creating an onion path to IP 0.0.0.0 with public key 000000..etc. as the first node. This is likely a bug, so making the error go away will hide that bug (if it is one). If it's not a bug, and we indeed intend to create an onion path starting with a non-existing node when we're using TCP, then zeroing out the memory makes sense, but not in those two places.

[kpp]

could start from

[iphydf]

I've fixed all the valgrind issues and we now have a CI test that checks it.