tox_conference_id_size() symbol missing

[naxuroqa]

Seems like the tox_conference_id_size function does not get exported:

objdump -TC /usr/lib/libtoxcore.so.2.8.0 | grep tox_conference                                                                               :(
0000000000035dc0 g    DF .text	00000000000000a7  Base        tox_conference_send_message
0000000000035b90 g    DF .text	0000000000000052  Base        tox_conference_peer_get_public_key
0000000000035cd0 g    DF .text	00000000000000e1  Base        tox_conference_join
0000000000035ed0 g    DF .text	0000000000000052  Base        tox_conference_get_title
0000000000035fa0 g    DF .text	000000000000001b  Base        tox_conference_get_chatlist_size
0000000000035bf0 g    DF .text	000000000000006f  Base        tox_conference_peer_number_is_ours
0000000000035a50 g    DF .text	000000000000003f  Base        tox_conference_delete
0000000000036050 g    DF .text	0000000000000066  Base        tox_conference_by_id
0000000000035fc0 g    DF .text	000000000000002a  Base        tox_conference_get_chatlist
0000000000035e70 g    DF .text	000000000000005f  Base        tox_conference_get_title_size
0000000000035ad0 g    DF .text	000000000000005f  Base        tox_conference_peer_get_name_size
0000000000036030 g    DF .text	0000000000000010  Base        tox_conference_get_id
0000000000035a90 g    DF .text	000000000000003d  Base        tox_conference_peer_count
00000000000360c0 g    DF .text	0000000000000083  Base        tox_conference_by_uid
0000000000035a10 g    DF .text	000000000000003d  Base        tox_conference_new
0000000000035b30 g    DF .text	0000000000000052  Base        tox_conference_peer_get_name
0000000000035ff0 g    DF .text	000000000000003d  Base        tox_conference_get_type
0000000000036040 g    DF .text	0000000000000006  Base        tox_conference_get_uid
0000000000035f30 g    DF .text	000000000000006f  Base        tox_conference_set_title
0000000000035c60 g    DF .text	000000000000006f  Base        tox_conference_invite

I'm using toxcore-0.2.8 from the arch packages.
https://www.archlinux.org/packages/community/x86_64/toxcore/

[nurupo]

Looks like it's declared but never defined.

$ grep 'id_size' * -R --colour
DHT.c:    const uint32_t cid_size = 1 + CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE + 1 + sizeof(uint64_t) + CRYPTO_MAC_SIZE;
DHT.c:    if (length < cid_size) { /* too short */
DHT.c:    const uint32_t data_size = length - cid_size;
tox.h:uint32_t tox_conference_uid_size(void);
tox.h:uint32_t tox_conference_id_size(void);

It should probably be added to those

c-toxcore/toxcore/tox_api.c

Lines 17 to 32 in 605dfe8

	CONST_FUNCTION(version_major, VERSION_MAJOR)
	CONST_FUNCTION(version_minor, VERSION_MINOR)
	CONST_FUNCTION(version_patch, VERSION_PATCH)
	CONST_FUNCTION(public_key_size, PUBLIC_KEY_SIZE)
	CONST_FUNCTION(secret_key_size, SECRET_KEY_SIZE)
	CONST_FUNCTION(nospam_size, NOSPAM_SIZE)
	CONST_FUNCTION(address_size, ADDRESS_SIZE)
	CONST_FUNCTION(max_name_length, MAX_NAME_LENGTH)
	CONST_FUNCTION(max_status_message_length, MAX_STATUS_MESSAGE_LENGTH)
	CONST_FUNCTION(max_friend_request_length, MAX_FRIEND_REQUEST_LENGTH)
	CONST_FUNCTION(max_message_length, MAX_MESSAGE_LENGTH)
	CONST_FUNCTION(max_custom_packet_size, MAX_CUSTOM_PACKET_SIZE)
	CONST_FUNCTION(hash_length, HASH_LENGTH)
	CONST_FUNCTION(file_id_length, FILE_ID_LENGTH)
	CONST_FUNCTION(max_filename_length, MAX_FILENAME_LENGTH)
	CONST_FUNCTION(max_hostname_length, MAX_HOSTNAME_LENGTH)

Perhaps someone has added TOX_CONFERENCE_ID_SIZE constant to tox.api.h and didn't realize that APIDSL auto-generated the function declaration for it, which is why the developer who added it didn't define it? Pinging @iphy and @zugz #1029.

[nurupo]

tox_conference_uid_size() and potentially some other API functions are not defined too.

[naxuroqa]

I'm automatically testing most functions in naxuroqa/vala-toxcore-c. I guess I should make sure that all macros exist and have the same return value as the function counterpart.

[sudden6]

Aren't the macros supposed to go away some time?

[naxuroqa]

You are right, they are deprecated already.
Is qtox using tox conference ids? (I expected qtox to find those missing functions first :) )

[sudden6]

No, we're not storing the group chats at the moment.