Skip to content

Rename dht->last_run #1788

@nurupo

Description

@nurupo
<nurupo> sudden6: it's a bit weird how in your PR you changed the meaning of dht->last_run. it used to store the last time do_DHT() has ran, but now it stores the current time instead
<nurupo> sudden6: https://github.com/TokTok/c-toxcore/pull/1708/files#diff-a44b0f16bfdccdd2e138a3b90ab3ab480129913d31c7cbfe5c0ae3e9aa7dfec0R2756
<nurupo> should have renamed it to cur_time or something
<sudden6> nurupo: true, could you add that to GH so it's not forgotten?
<sudden6> I'll implement it together with all the other changes then

It's just odd to see the code use something called "last_run" for the current time. Might get the wrong idea to whoever reads the code.

Metadata

Metadata

Assignees

Labels

P3Low priority

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions