Skip to content

Tox save file format/loader doesn't limit or check the number of frozen peers #2083

@sudden6

Description

@sudden6

A *.tox save file with an excessive number of frozen peers might lead to out-of-memory issues:
https://github.com/TokTok/c-toxcore/runs/5266641816?check_suite_focus=true#step:5:479

Relevant line: https://github.com/TokTok/c-toxcore/blob/master/toxcore/group.c#L3426

I guess in practice the file length is bounded, but our implementation doesn't check that.

The question is, do we want a hardcoded limit on that value? Or do we just use a few of the frozen peers and ignore the rest?

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium prioritybugBug fix for the user, not a fix to a build script

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions