Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic bitrate management in ToxAV #232

Open
ovalseven8 opened this issue Nov 5, 2016 · 2 comments
Open

Fix automatic bitrate management in ToxAV #232

ovalseven8 opened this issue Nov 5, 2016 · 2 comments
Labels
bug Bug fix for the user, not a fix to a build script P3 Low priority toxav Audio/video
Milestone

Comments

@ovalseven8
Copy link

In 2015 the new ToxAV API had been merged.

Among other things, the introduced bitrate management hasn't really worked well.

Because of that, it had been disabled in qTox: qTox/qTox@db52ef6

@tux3 wrote:

For some users on poor connections, toxav would suggest lower and lower bitratres until reaching zero and disabling audio/video entirely, toxav would then not raise the bitrate back and the only way to re-enable audio/video would have been to change A/V sources or restart the call

We now log toxav's recommendation, but ignore it

@ovalseven8 ovalseven8 added bug Bug fix for the user, not a fix to a build script toxav Audio/video labels Nov 5, 2016
@iphydf iphydf modified the milestone: v0.3.0 Nov 5, 2016
@alexeysvrv
Copy link

@mannol

@GrayHatter
Copy link

GrayHatter commented Nov 6, 2016

Client bitrate management is a distraction. Either toxav needs to hand a lot more than just bitrate management to the client, or it needs to take everything away. This is a case where I don't think you can hold your cake and eat it too.

@iphydf iphydf modified the milestone: v0.3.0 Jan 10, 2017
@iphydf iphydf added the P3 Low priority label Jan 12, 2017
@iphydf iphydf added this to the v0.2.x milestone Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script P3 Low priority toxav Audio/video
Projects
None yet
Development

No branches or pull requests

4 participants