Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the packet mutation in toxav's bwcontroller. #100

Merged
merged 1 commit into from Sep 8, 2016
Merged

Remove the packet mutation in toxav's bwcontroller. #100

merged 1 commit into from Sep 8, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 5, 2016 •
edited

  1. This mutation is never observed outside the function.
  2. If it were (it's not), it would be undefined behaviour, since the
    packet data goes out of scope a few instructions after the callback
    returns.

This change is Reviewable

@iphydf
Copy link
Member Author

iphydf commented Sep 5, 2016

@isotoxin

@iphydf iphydf force-pushed the remove-packet-mutation branch 4 times, most recently from 3f8b98d to afce7e7 Compare September 7, 2016 08:55
@JFreegman
Copy link
Member

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Sep 7, 2016

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf force-pushed the remove-packet-mutation branch 2 times, most recently from b73be40 to bf558bf Compare September 7, 2016 22:49
@iphydf
Remove the packet mutation in toxav's bwcontroller.
d5f9344 
1. This mutation is never observed outside the function.
2. If it were (it's not), it would be undefined behaviour, since the
   packet data goes out of scope a few instructions after the callback
   returns.
@mannol
Copy link

mannol commented Sep 8, 2016

:lgtm_strong:

Comments from Reviewable

@GrayHatter
Copy link

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf merged commit d5f9344 into TokTok:master Sep 8, 2016
@iphydf iphydf deleted the remove-packet-mutation branch September 8, 2016 10:33
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GrayHatter GrayHatter

@JFreegman JFreegman

@nurupo nurupo

@mannol mannol

Labels
None yet
Projects
None yet
Milestone
v0.0.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iphydf @JFreegman @nurupo @mannol @GrayHatter