Skip to content

Split out conference type (text/av) from identifier.#1016

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:group-identifier
Aug 11, 2018
Merged

Split out conference type (text/av) from identifier.#1016
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:group-identifier

Conversation

@iphydf

@iphydf iphydf commented Jul 19, 2018

Copy link
Copy Markdown
Member

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jul 19, 2018
@iphydf iphydf force-pushed the group-identifier branch from 8af3d71 to 2b32238 Compare July 19, 2018 21:37
@zugz

zugz commented Jul 20, 2018 via email

Copy link
Copy Markdown

@iphydf

iphydf commented Jul 21, 2018

Copy link
Copy Markdown
Member Author

@zugz would you suggest renaming the public API function as well?

@iphydf iphydf force-pushed the group-identifier branch from 2b32238 to a26ee1d Compare July 21, 2018 22:10
@iphydf

iphydf commented Jul 21, 2018

Copy link
Copy Markdown
Member Author

Anyway, I've renamed identifier to uid.

@iphydf iphydf force-pushed the group-identifier branch 2 times, most recently from b265edb to bcb24ff Compare July 23, 2018 20:07
@zugz

zugz commented Jul 23, 2018 via email

Copy link
Copy Markdown

@iphydf iphydf force-pushed the group-identifier branch 3 times, most recently from 8d41014 to 1d3e5fe Compare August 4, 2018 09:47
@iphydf

iphydf commented Aug 4, 2018

Copy link
Copy Markdown
Member Author

@zugz done.

@iphydf iphydf force-pushed the group-identifier branch from 1d3e5fe to a4ef748 Compare August 4, 2018 09:49
@iphydf

iphydf commented Aug 4, 2018

Copy link
Copy Markdown
Member Author

Should we revert "id" back to "identifier"?

@iphydf iphydf force-pushed the group-identifier branch from a4ef748 to 150d5dd Compare August 4, 2018 13:18
@zugz

zugz commented Aug 8, 2018 via email

Copy link
Copy Markdown

@iphydf iphydf force-pushed the group-identifier branch 2 times, most recently from ea58e0e to 08999a6 Compare August 10, 2018 00:20
@iphydf iphydf merged commit 678720d into TokTok:master Aug 11, 2018
@iphydf iphydf deleted the group-identifier branch August 11, 2018 16:28
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.6 Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants