More fixed_width ints and incorporating file_saving_test.c#1025
More fixed_width ints and incorporating file_saving_test.c#1025iphydf merged 1 commit intoTokTok:masterfrom
Conversation
auto_tests/file_saving_test.c
Outdated
There was a problem hiding this comment.
Let's avoid sized-int in printf calls.
auto_tests/encryptsave_test.c
Outdated
There was a problem hiding this comment.
Maybe just get rid of the SRunner stuff. That's just old compat stuff. Now we just call the test function directly (and we shouldn't use START_TEST anymore, just declare a static function manually).
There was a problem hiding this comment.
I was never quite sure what SRunner does tbqh. Is my HEAD now equivalent?
hugbubby
force-pushed
the
stdint
branch
2 times, most recently
from
63f1cad to
3917c41
Compare
auto_tests/encryptsave_test.c
Outdated
auto_tests/file_saving_test.c
Outdated
auto_tests/file_transfer_test.c
Outdated
auto_tests/file_transfer_test.c
Outdated
There was a problem hiding this comment.
%llu is not supported on windows. Change to %lu and cast to unsigned long.
auto_tests/file_transfer_test.c
Outdated
auto_tests/file_transfer_test.c
Outdated
auto_tests/file_transfer_test.c
Outdated
There was a problem hiding this comment.
No space after the cast (did you do this or did astyle?).
auto_tests/file_transfer_test.c
Outdated
There was a problem hiding this comment.
Cast the result of the subtraction to unsigned long.
auto_tests/file_transfer_test.c
Outdated
auto_tests/file_transfer_test.c
Outdated
hugbubby
force-pushed
the
stdint
branch
3 times, most recently
from
c6adc24 to
6397e17
Compare
|
👍? |
iphydf
left a comment
iphydf
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 LGTMs obtained
auto_tests/file_transfer_test.c, line 50 at r2 (raw file):
Previously, iphydf wrote…
The outer () is now redundant.
It's still redundant. I didn't mean the inner (), I meant the outer (). Please put the inner ones back, we currently have that as a standard. We may change that once we use a better code formatter than astyle.
hugbubby
force-pushed
the
stdint
branch
6 times, most recently
from
7635758 to
ffa038f
Compare
|
dun |
The file_saving_test.c was not included in the cmake list and thus was ignored by travis and "make check". I found this out while introducing ck_assert_msg into the integration test. Furthermore, removed some variable width integers from encryptsave_test.c, and the SRunner utilization. Implemmented ck_assert_msg, reorganized some loops, and removed some longs in file_transfer_test.c.
2 participants
The file_saving_test.c was not included in the cmake list
and thus was ignored by travis and "make check". I found this
out while introducing ck_assert_msg into the integration test.
Also removed some variable width integers from encryptsave_test.c
and implemented ck_assert_msg, reorganized some loops,
and removed some longs in file_transfer_test.c.
This change is