Add by_id and get_id functions, renaming from *_uid.#1029
Merged
iphydf merged 1 commit intoTokTok:masterfrom Jul 28, 2018
Merged
Add by_id and get_id functions, renaming from *_uid.#1029iphydf merged 1 commit intoTokTok:masterfrom
by_id and get_id functions, renaming from *_uid.#1029iphydf merged 1 commit intoTokTok:masterfrom
Conversation
|
|
zugz
approved these changes
Jul 28, 2018
`UID` sounds like `User ID`. While it is a Unique ID, the property of an "identifier" is generally that it identifies a unique thing, so the 'U' is redundant, and `GUID` as a globally unique id (which is likely also true for these IDs) has a specific meaning and syntax, so we're not using that. So, we just say conference `id`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIDsounds likeUser ID. While it is a Unique ID, the property of an"identifier" is generally that it identifies a unique thing, so the 'U'
is redundant, and
GUIDas a globally unique id (which is likely alsotrue for these IDs) has a specific meaning and syntax, so we're not using
that. So, we just say conference
id.This change is