Add callback for successful connection to a conference#1042
Merged
Conversation
|
|
zugz
force-pushed
the
confConnectedCallback
branch
2 times, most recently
from
f7f88d7 to
77329f8
Compare
iphydf
changed the title
iphydf
force-pushed
the
confConnectedCallback
branch
2 times, most recently
from
f4df1f3 to
e31a91e
Compare
iphydf
reviewed
Aug 4, 2018
Member
There was a problem hiding this comment.
Can you document somewhere what guarantees this gives the client? Perhaps in the docs for "invite", explain in what state it's valid to call "invite", and when it stops being valid.
iphydf
requested changes
Aug 4, 2018
Member
There was a problem hiding this comment.
Let's remove this Function(...) stuff. It's documentation that's easy to get out of date and it's not really useful.
iphydf
force-pushed
the
confConnectedCallback
branch
from
e31a91e to
77329f8
Compare
iphydf
reviewed
Aug 4, 2018
Member
There was a problem hiding this comment.
This is now different, since we have a struct Tox.
zugz
force-pushed
the
confConnectedCallback
branch
from
77329f8 to
fea22ba
Compare
Author
|
Perhaps in the docs for "invite", explain in what state it's valid to
call "invite", and when it stops being valid.
Done
|
zugz
force-pushed
the
confConnectedCallback
branch
3 times, most recently
from
74dbfb4 to
7fedd86
Compare
iphydf
approved these changes
Aug 12, 2018
Member
|
@zugz please rebase/squash, then merge. |
zugz
force-pushed
the
confConnectedCallback
branch
2 times, most recently
from
4a69883 to
1ab5b90
Compare
zugz
force-pushed
the
confConnectedCallback
branch
from
1ab5b90 to
d56ab5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(based on #1035)
This change is