Skip to content

Use tokstyle in the cmake travis build.#1053

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:tokstyle
Aug 13, 2018
Merged

Use tokstyle in the cmake travis build.#1053
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:tokstyle

Conversation

@iphydf

@iphydf iphydf commented Aug 6, 2018

Copy link
Copy Markdown
Member

This checks that (some of) the code follows some simplicity and naming
guidelines set by the tool.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 6, 2018
@iphydf iphydf force-pushed the tokstyle branch 2 times, most recently from dd9377d to 3098874 Compare August 6, 2018 21:51

@hugbubby hugbubby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained


.travis/cmake-linux, line 12 at r1 (raw file):


travis_install() {
  curl -L https://github.com/TokTok/hs-tools/releases/download/v0.2/hs-tools-v0.2.tar.gz | tar xz -C $HOME

Instead of doing this, we can do the following:

  1. Use the github api to automatically get the latest release for the tokstyle tool, so we don't have to update this file every release.
    Solution here: https://stackoverflow.com/questions/24085978/github-url-for-latest-release-of-the-download-file

  2. Create releases for the tokstyle tool and automatically download that package (and whatever hs-tools we believe we need in the future) rather than gather them up in this hs-tools repo and download that.
    We're not an operating system - we will solve more problems by doing rolling release than by wasting time gathering them up into a single hs-tools repo package and testing that beforehand.

@iphydf iphydf left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained


.travis/cmake-linux, line 12 at r1 (raw file):

Previously, hugbubby wrote…

Instead of doing this, we can do the following:

  1. Use the github api to automatically get the latest release for the tokstyle tool.
    Solution here: https://stackoverflow.com/questions/24085978/github-url-for-latest-release-of-the-download-file

  2. Create releases for the tokstyle tool and automatically download that package rather than gather them up in this hs-tools repo and download that.
    We're not an operating system - we will solve more problems by doing rolling release than by wasting time gathering them up into a single hs-tools repo package and testing that beforehand.

I like this idea. I'd still like to do this for now, and then change this repo together with all the haskell repos so they behave the same. The hs-tools repo will stay, because we want to build some tools that aren't developed by us there.

I'll make a PR into tokstyle to make releases, but I don't want that to block the adoption of tokstyle into the c-toxcore build, since without it, I have to manually run it on every PR.

@iphydf iphydf force-pushed the tokstyle branch 5 times, most recently from 3279637 to 0ca341b Compare August 12, 2018 13:56

@iphydf iphydf left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained


.travis/cmake-linux, line 12 at r1 (raw file):

Previously, iphydf wrote…

I like this idea. I'd still like to do this for now, and then change this repo together with all the haskell repos so they behave the same. The hs-tools repo will stay, because we want to build some tools that aren't developed by us there.

I'll make a PR into tokstyle to make releases, but I don't want that to block the adoption of tokstyle into the c-toxcore build, since without it, I have to manually run it on every PR.

Done.

@iphydf iphydf force-pushed the tokstyle branch 3 times, most recently from d30ed5d to 9283be7 Compare August 12, 2018 16:31

@hugbubby hugbubby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

This checks that (some of) the code follows some simplicity and naming
guidelines set by the tool.
@iphydf iphydf merged commit 3e3a881 into TokTok:master Aug 13, 2018
@iphydf iphydf deleted the tokstyle branch August 13, 2018 21:39
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.6 Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants