Assert that we don't divide by 0 in random_testing.cc.#1059
Merged
iphydf merged 1 commit intoTokTok:masterfrom Aug 12, 2018
Merged
Assert that we don't divide by 0 in random_testing.cc.#1059iphydf merged 1 commit intoTokTok:masterfrom
iphydf merged 1 commit intoTokTok:masterfrom
Conversation
zugz
approved these changes
Aug 12, 2018
This is always true due to the condition function, but if we introduce a bug that makes the condition not be applied, this causes undefined behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is always true due to the condition function, but if we introduce a
bug that makes the condition not be applied, this causes undefined
behaviour.
This change is