Force storing the result of crypto_memcmp in the test.#1061
Merged
Conversation
f1b2c58 to
36286fb
Compare
36286fb to
e2b1d8c
Compare
robinlinden
approved these changes
Aug 23, 2018
robinlinden
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
So we don't accidentally elide the call given that it's a pure function and its result isn't used.
e2b1d8c to
ff342a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1061 +/- ##
========================================
+ Coverage 82.4% 82.6% +0.2%
========================================
Files 80 80
Lines 14317 14318 +1
========================================
+ Hits 11801 11840 +39
+ Misses 2516 2478 -38
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we don't accidentally elide the call given that it's a pure function
and its result isn't used.
This change is