Avoid passing -1 as friend connection to new groups.#1063
Merged
iphydf merged 1 commit intoTokTok:masterfrom Aug 13, 2018
Merged
Avoid passing -1 as friend connection to new groups.#1063iphydf merged 1 commit intoTokTok:masterfrom
iphydf merged 1 commit intoTokTok:masterfrom
Conversation
iphydf
force-pushed
the
avoid-negative-friendcon
branch
3 times, most recently
from
fe93536 to
07f70e7
Compare
robinlinden
approved these changes
Aug 13, 2018
robinlinden
left a comment
robinlinden
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
Somehow it still works because the lower levels can deal with inconsistent/broken state, but this lets us avoid that broken state in the first place. If a friend connection doesn't exist, we don't add it to our group.
iphydf
force-pushed
the
avoid-negative-friendcon
branch
from
07f70e7 to
b77e407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow it still works because the lower levels can deal with
inconsistent/broken state, but this lets us avoid that broken state in
the first place. If a friend connection doesn't exist, we don't add it to
our group.
This change is