Fix a few warnings from clang.#1068
Merged
Merged
Conversation
iphydf
force-pushed
the
warnings
branch
2 times, most recently
from
8962d3e to
c6ddecd
Compare
nurupo
approved these changes
Aug 12, 2018
Member
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: 0 of 1 LGTMs obtained, and 1 stale (waiting on @nurupo)
iphydf
force-pushed
the
warnings
branch
2 times, most recently
from
a1655e3 to
34b1361
Compare
Member
Author
|
@nurupo PTAL, it's been rebased. |
Also remove the use of a VLA in a context where there can be unbounded memory allocations.
nurupo
approved these changes
Aug 12, 2018
Member
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status: 0 of 1 LGTMs obtained, and 1 stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove the use of a VLA in a context where there can be unbounded
memory allocations.
This change is