Change while-loop to for-loop to express for-each-frame.#1081
Merged
iphydf merged 1 commit intoTokTok:masterfrom Aug 25, 2018
Merged
Change while-loop to for-loop to express for-each-frame.#1081iphydf merged 1 commit intoTokTok:masterfrom
iphydf merged 1 commit intoTokTok:masterfrom
Conversation
iphydf
force-pushed
the
video-style-2
branch
4 times, most recently
from
6767ec4 to
65be401
Compare
zoff99
changed the title
|
this one need checks in the video lab setup before merging. |
robinlinden
approved these changes
Aug 13, 2018
robinlinden
left a comment
robinlinden
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
iphydf
force-pushed
the
video-style-2
branch
3 times, most recently
from
eca008d to
7f3207d
Compare
iphydf
changed the title
sudden6
approved these changes
Aug 16, 2018
sudden6
left a comment
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: 0 of 1 approvals obtained
* Assignments can't be used as expressions, therefore `while` loops should not be used as a `for-each` construct. Use `for`, instead.
Codecov Report
@@ Coverage Diff @@
## master #1081 +/- ##
========================================
+ Coverage 82.4% 82.7% +0.2%
========================================
Files 80 80
Lines 14341 14341
========================================
+ Hits 11826 11861 +35
+ Misses 2515 2480 -35
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is