Fix coding style in rtp module. - #1083
Merged
Merged
Conversation
iphydf
force-pushed
the
rtp-style
branch
2 times, most recently
from
August 12, 2018 23:18
cc69f9b to
32cbfc7
Compare
* Named callback types only. * No anonymous enums or structs. * `++i` instead of `i++`. * Don't use enums to specify integer constants. Enums should be enumerations. All values of an enum type should be listed[1]. [1] I don't know what to do about bit masks yet, but given that enums by C standard can only go up to 32767 portably and 2^31 in reality, they are probably not useful for 64 bit bit masks.
hugbubby
reviewed
Aug 13, 2018
| size_t rtp_header_pack(uint8_t *const rdata, const struct RTPHeader *header) | ||
| { | ||
| uint8_t *p = rdata; | ||
| *p++ = (header->ve & 3) << 6 |
hugbubby
approved these changes
Aug 13, 2018
hugbubby
approved these changes
Aug 13, 2018
hugbubby
left a comment
hugbubby
left a comment
Member
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
zoff99
approved these changes
Aug 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
++iinstead ofi++.enumerations. All values of an enum type should be listed[1].
[1] I don't know what to do about bit masks yet, but given that enums by
C standard can only go up to 32767 portably and 2^31 in reality, they are
probably not useful for 64 bit bit masks.
This change is