Skip to content

Install the DHT_bootstrap binary on make install.#1092

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:install-dht-bootstrap
Aug 23, 2018
Merged

Install the DHT_bootstrap binary on make install.#1092
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:install-dht-bootstrap

Conversation

@iphydf

@iphydf iphydf commented Aug 16, 2018

Copy link
Copy Markdown
Member

We didn't install it before, only tox-bootstrapd.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 16, 2018

@robinlinden robinlinden left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

We didn't install it before, only `tox-bootstrapd`.
@iphydf
iphydf force-pushed the install-dht-bootstrap branch from 0faf3da to 2730c95 Compare August 23, 2018 21:33
@codecov

codecov Bot commented Aug 23, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1092 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1092     +/-   ##
========================================
- Coverage    82.7%   82.4%   -0.4%     
========================================
  Files          80      80             
  Lines       14317   14317             
========================================
- Hits        11849   11801     -48     
- Misses       2468    2516     +48
Impacted Files Coverage Δ
auto_tests/network_test.c 90.3% <0%> (-9.7%) ⬇️
auto_tests/typing_test.c 94% <0%> (-6%) ⬇️
auto_tests/toxav_many_test.c 92.5% <0%> (-4.1%) ⬇️
toxav/msi.c 64.5% <0%> (-2.3%) ⬇️
toxcore/group.c 71.7% <0%> (-1.5%) ⬇️
toxav/toxav.c 67.6% <0%> (-1.2%) ⬇️
toxcore/net_crypto.c 93.6% <0%> (-0.2%) ⬇️
toxcore/Messenger.c 86.1% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f4ae6...2730c95. Read the comment docs.

@iphydf
iphydf merged commit 2730c95 into TokTok:master Aug 23, 2018
@iphydf
iphydf deleted the install-dht-bootstrap branch August 23, 2018 22:26
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants