Skip to content

Enable color diagnostics on circleci.#1102

Merged
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:diagnostics-color
Aug 21, 2018
Merged

Enable color diagnostics on circleci.#1102
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:diagnostics-color

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Aug 19, 2018

See ninja-build/ninja#814


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 19, 2018
Copy link
Copy Markdown

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf force-pushed the diagnostics-color branch from 88a847d to 74e685b Compare August 21, 2018 17:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2018

Codecov Report

Merging #1102 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1102     +/-   ##
========================================
- Coverage    82.6%   82.4%   -0.3%     
========================================
  Files          80      80             
  Lines       14316   14316             
========================================
- Hits        11834   11801     -33     
- Misses       2482    2515     +33
Impacted Files Coverage Δ
toxcore/crypto_core_test.cc 90% <0%> (-10%) ⬇️
auto_tests/toxav_many_test.c 92.5% <0%> (-4.1%) ⬇️
auto_tests/toxav_basic_test.c 82.7% <0%> (-2.2%) ⬇️
toxcore/friend_connection.c 93.6% <0%> (-2.1%) ⬇️
toxav/toxav.c 68.1% <0%> (-1.5%) ⬇️
toxav/msi.c 65.6% <0%> (-1.2%) ⬇️
toxcore/onion_client.c 95% <0%> (-0.4%) ⬇️
toxcore/Messenger.c 85.7% <0%> (-0.3%) ⬇️
toxcore/net_crypto.c 93.6% <0%> (ø) ⬆️
auto_tests/conference_simple_test.c 96.8% <0%> (+3.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0aea1...74e685b. Read the comment docs.

@iphydf iphydf merged commit 74e685b into TokTok:master Aug 21, 2018
@iphydf iphydf deleted the diagnostics-color branch August 21, 2018 17:31
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants