Avoid redefining macros from different files.#1104
Merged
Conversation
57637f7 to
3771981
Compare
3771981 to
7aa57af
Compare
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
- Coverage 82.56% 82.46% -0.11%
==========================================
Files 80 80
Lines 14316 14316
==========================================
- Hits 11820 11805 -15
- Misses 2496 2511 +15
Continue to review full report at Codecov.
|
e0ff
approved these changes
Aug 20, 2018
e0ff
left a comment
Member
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @endoffile78)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is