Skip to content

Always print output on failure in cmake tests on Travis.#1107

Merged
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:output-on-failure
Aug 21, 2018
Merged

Always print output on failure in cmake tests on Travis.#1107
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:output-on-failure

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Aug 21, 2018

Not only the second time it fails.


This change is Reviewable

Copy link
Copy Markdown
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf force-pushed the output-on-failure branch from beadc6c to 46b48f0 Compare August 21, 2018 17:52
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 21, 2018

Codecov Report

Merging #1107 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1107    +/-   ##
=======================================
+ Coverage    81.3%   82.4%    +1%     
=======================================
  Files          79      80     +1     
  Lines       14219   14316    +97     
=======================================
+ Hits        11572   11804   +232     
+ Misses       2647    2512   -135
Impacted Files Coverage Δ
toxav/toxav.c 68% <0%> (-1.7%) ⬇️
toxcore/group.c 71.7% <0%> (-1.5%) ⬇️
toxav/msi.c 65.3% <0%> (-1.4%) ⬇️
auto_tests/tox_many_tcp_test.c 100% <0%> (ø)
auto_tests/toxav_many_test.c 97.2% <0%> (+0.6%) ⬆️
toxcore/Messenger.c 85.8% <0%> (+0.8%) ⬆️
toxcore/network.c 83.4% <0%> (+1.4%) ⬆️
toxcore/onion_client.c 95% <0%> (+1.7%) ⬆️
toxcore/TCP_connection.c 78.2% <0%> (+2.8%) ⬆️
toxcore/onion.c 98.7% <0%> (+3.2%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b73b62...46b48f0. Read the comment docs.

@iphydf iphydf merged commit 46b48f0 into TokTok:master Aug 21, 2018
@iphydf iphydf deleted the output-on-failure branch August 21, 2018 18:31
@iphydf iphydf added this to the v0.2.x milestone Aug 25, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants