Skip to content

Add check to make sure tox was created successfully#1110

Merged
iphydf merged 1 commit intoTokTok:masterfrom
e0ff:add-check
Aug 22, 2018
Merged

Add check to make sure tox was created successfully#1110
iphydf merged 1 commit intoTokTok:masterfrom
e0ff:add-check

Conversation

@e0ff
Copy link
Copy Markdown
Member

@e0ff e0ff commented Aug 22, 2018

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2018

Codecov Report

Merging #1110 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1110     +/-   ##
========================================
+ Coverage    82.7%   82.7%   +<.1%     
========================================
  Files          80      80             
  Lines       14316   14317      +1     
========================================
+ Hits        11841   11849      +8     
+ Misses       2475    2468      -7
Impacted Files Coverage Δ
auto_tests/save_compatibility_test.c 88.1% <100%> (+0.2%) ⬆️
auto_tests/set_name_test.c 93.6% <0%> (-6.4%) ⬇️
toxav/toxav.c 68.8% <0%> (-0.7%) ⬇️
toxcore/net_crypto.c 93.7% <0%> (-0.6%) ⬇️
toxcore/Messenger.c 86.2% <0%> (+0.3%) ⬆️
toxav/msi.c 66.7% <0%> (+0.5%) ⬆️
toxcore/tox.c 66.6% <0%> (+0.9%) ⬆️
toxcore/network.c 84.8% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b1783...76f4ae6. Read the comment docs.

Copy link
Copy Markdown
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf merged commit 76f4ae6 into TokTok:master Aug 22, 2018
@iphydf iphydf added this to the v0.2.x milestone Aug 25, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants