Stop using massive macros in toxav_basic_test.#1120
Conversation
c862666 to
fb07b6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
========================================
+ Coverage 82.5% 82.5% +<.1%
========================================
Files 80 80
Lines 14318 14339 +21
========================================
+ Hits 11819 11838 +19
- Misses 2499 2501 +2
Continue to review full report at Codecov.
|
fb07b6f to
6ad6db4
Compare
sudden6
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @iphydf)
auto_tests/toxav_basic_test.c, line 107 at r1 (raw file):
int a_br, int v_br) { memset(AliceCC, 0, sizeof(CallControl));
memset on a struct is not very nice, at least add a todo/fixme comment
6ad6db4 to
97ee97a
Compare
iphydf
left a comment
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @sudden6)
auto_tests/toxav_basic_test.c, line 107 at r1 (raw file):
Previously, sudden6 wrote…
memset on a struct is not very nice, at least add a todo/fixme comment
Done.
Turned a huge macro into a function. Macros are a pain to debug.
97ee97a to
853a2a1
Compare
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 1 change requests, 0 of 1 approvals obtained
Turned a huge macro into a function. Macros are a pain to debug.
This change is