Skip to content

Fix the PORT_ALLOC failure of save_compatibility_test.#1124

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:fix-port-alloc
Aug 25, 2018
Merged

Fix the PORT_ALLOC failure of save_compatibility_test.#1124
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:fix-port-alloc

Conversation

@iphydf

@iphydf iphydf commented Aug 25, 2018

Copy link
Copy Markdown
Member

tox_new_log has a much larger range of ports it can select from.


This change is Reviewable

`tox_new_log` has a much larger range of ports it can select from.
@iphydf iphydf added this to the v0.2.x milestone Aug 25, 2018
@iphydf iphydf requested a review from e0ff August 25, 2018 22:29

@e0ff e0ff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @endoffile78)

@codecov

codecov Bot commented Aug 25, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1124 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1124     +/-   ##
========================================
- Coverage    82.7%   82.4%   -0.3%     
========================================
  Files          80      80             
  Lines       14341   14342      +1     
========================================
- Hits        11861   11829     -32     
- Misses       2480    2513     +33
Impacted Files Coverage Δ
auto_tests/save_compatibility_test.c 88.3% <100%> (+0.1%) ⬆️
toxcore/logger.c 88.8% <0%> (-5.6%) ⬇️
toxav/audio.c 65.7% <0%> (-4.4%) ⬇️
toxcore/network.c 83.4% <0%> (-1.5%) ⬇️
toxav/msi.c 65.6% <0%> (-1.2%) ⬇️
toxcore/tox.c 65.7% <0%> (-1%) ⬇️
toxcore/friend_connection.c 93.6% <0%> (-0.9%) ⬇️
toxcore/Messenger.c 85.7% <0%> (-0.6%) ⬇️
toxav/toxav.c 68.1% <0%> (-0.5%) ⬇️
toxcore/onion_client.c 95% <0%> (-0.2%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99c131...17e8195. Read the comment docs.

@iphydf iphydf merged commit 17e8195 into TokTok:master Aug 25, 2018
@iphydf iphydf deleted the fix-port-alloc branch August 25, 2018 22:48
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants