Add some tests for ping_array.#1128
Merged
Merged
Conversation
iphydf
force-pushed
the
ping-array-test
branch
9 times, most recently
from
9f85f12 to
b8a2a82
Compare
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
========================================
+ Coverage 82.4% 82.5% +<.1%
========================================
Files 80 81 +1
Lines 14345 14415 +70
========================================
+ Hits 11823 11894 +71
+ Misses 2522 2521 -1
Continue to review full report at Codecov.
|
robinlinden
approved these changes
Aug 26, 2018
robinlinden
left a comment
robinlinden
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status: 0 of 1 approvals obtained
iphydf
force-pushed
the
ping-array-test
branch
2 times, most recently
from
d4a4fb3 to
6d00e53
Compare
No timeout test here yet, because we don't yet have the ability to manipulate time at will, so we would have to actually sleep.
iphydf
force-pushed
the
ping-array-test
branch
from
6d00e53 to
a1035cf
Compare
sudden6
approved these changes
Aug 26, 2018
sudden6
left a comment
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 8 of 9 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
sudden6
approved these changes
Aug 26, 2018
sudden6
left a comment
sudden6
left a comment
There was a problem hiding this comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No timeout test here yet, because we don't yet have the ability to
manipulate time at will, so we would have to actually sleep.
This change is