Merged
Conversation
sudden6
approved these changes
Aug 26, 2018
sudden6
left a comment
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained
Changes: * 100 columns maximum (not strict, can be a bit more sometimes). * No space after cast.
iphydf
force-pushed
the
format-crypto-core
branch
from
dc01352 to
acc19a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
========================================
- Coverage 82.5% 82.5% -0.1%
========================================
Files 81 81
Lines 14415 14414 -1
========================================
- Hits 11897 11895 -2
- Misses 2518 2519 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This change is