Use bool in place of 0/1 int values.#1132
Conversation
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @iphydf)
toxcore/DHT.h, line 206 at r1 (raw file):
uint8_t shared_key[CRYPTO_SHARED_KEY_SIZE]; uint32_t times_requested; bool stored; /* 0 if not, 1 if is */
update comment to true and false or maybe remove entirely, IMO it's clear now
toxcore/network.c, line 955 at r1 (raw file):
* unset means unequal * * returns 0 when not equal or when uninitialized
update comment
toxcore/network.c, line 1003 at r1 (raw file):
* unset means unequal * * returns 0 when not equal or when uninitialized
update comment
toxcore/network.c, line 1144 at r1 (raw file):
* address: dotted notation (IPv4: quad, IPv6: 16) or colon notation (IPv6) * * returns 1 on success, 0 on failure
update comment
toxcore/network.c, line 1176 at r1 (raw file):
* IP: family and the value is set on success * * returns 1 on success, 0 on failure
update comment
toxcore/network.c, line 1322 at r1 (raw file):
* returns in *tro a matching address (IPv6 or IPv4) * returns in *extra, if not NULL, an IPv4 address, if to->family was AF_UNSPEC * returns 1 on success
update comment
sudden6
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @iphydf)
iphydf
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @sudden6)
toxcore/DHT.h, line 206 at r1 (raw file):
Previously, sudden6 wrote…
update comment to
trueandfalseor maybe remove entirely, IMO it's clear now
Done.
toxcore/network.c, line 955 at r1 (raw file):
Previously, sudden6 wrote…
update comment
Done.
toxcore/network.c, line 1003 at r1 (raw file):
Previously, sudden6 wrote…
update comment
Done.
toxcore/network.c, line 1144 at r1 (raw file):
Previously, sudden6 wrote…
update comment
Done.
toxcore/network.c, line 1176 at r1 (raw file):
Previously, sudden6 wrote…
update comment
Done.
toxcore/network.c, line 1322 at r1 (raw file):
Previously, sudden6 wrote…
update comment
Done.
Codecov Report
@@ Coverage Diff @@
## master #1132 +/- ##
========================================
- Coverage 82.5% 82.4% -0.1%
========================================
Files 81 81
Lines 14437 14437
========================================
- Hits 11912 11903 -9
- Misses 2525 2534 +9
Continue to review full report at Codecov.
|
This change is