Skip to content

Remove the use of CLOCK_MONOTONIC_RAW.#1136

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:no-clock-raw
Aug 30, 2018
Merged

Remove the use of CLOCK_MONOTONIC_RAW.#1136
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:no-clock-raw

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Aug 26, 2018

The raw clock isn't subject to NTP adjustments. It may run less
accurately than the regular monotonic clock. I see no reason why raw
would be better for tox than the normal one.

This avoids one piece of OS-specific ifdef'd code.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 26, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2018

Codecov Report

Merging #1136 into master will decrease coverage by 1.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1136     +/-   ##
========================================
- Coverage    82.5%   81.4%   -1.2%     
========================================
  Files          82      81      -1     
  Lines       14478   14381     -97     
========================================
- Hits        11958   11711    -247     
- Misses       2520    2670    +150
Impacted Files Coverage Δ
toxcore/mono_time.c 92.8% <ø> (ø) ⬆️
toxcore/friend_connection.c 85.1% <0%> (-9.5%) ⬇️
toxcore/TCP_server.c 69.5% <0%> (-5.5%) ⬇️
toxcore/net_crypto.c 89.6% <0%> (-3.8%) ⬇️
toxcore/list.c 89.6% <0%> (-3.5%) ⬇️
toxcore/TCP_connection.c 75.4% <0%> (-2.9%) ⬇️
toxcore/onion.c 95.9% <0%> (-2.9%) ⬇️
toxav/msi.c 64.2% <0%> (-2%) ⬇️
toxcore/onion_client.c 93.6% <0%> (-1.6%) ⬇️
toxcore/network.c 82.3% <0%> (-1.1%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cd476...730e4cf. Read the comment docs.

Copy link
Copy Markdown

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

The raw clock isn't subject to NTP adjustments. It may run less
accurately than the regular monotonic clock. I see no reason why raw
would be better for tox than the normal one.

This avoids one piece of OS-specific ifdef'd code.
@iphydf iphydf merged commit 730e4cf into TokTok:master Aug 30, 2018
@iphydf iphydf deleted the no-clock-raw branch August 30, 2018 22:14
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants