Clean up add_to_list function a bit.#1140
Merged
Merged
Conversation
zugz
requested changes
Aug 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #1140 +/- ##
========================================
+ Coverage 82.4% 82.6% +0.1%
========================================
Files 82 82
Lines 14478 14478
========================================
+ Hits 11943 11965 +22
+ Misses 2535 2513 -22
Continue to review full report at Codecov.
|
zugz
approved these changes
Aug 30, 2018
Can't trivially get rid of recursion here, since it's a non-linear recursive function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't trivially get rid of recursion here, since it's a non-linear
recursive function.
This change is