Skip to content

Fix login issue on Travis-CI FreeBSD build#1145

Merged
iphydf merged 1 commit into
TokTok:masterfrom
nurupo:travis-freebsd-poweroff-fix
Sep 2, 2018
Merged

Fix login issue on Travis-CI FreeBSD build#1145
iphydf merged 1 commit into
TokTok:masterfrom
nurupo:travis-freebsd-poweroff-fix

Conversation

@nurupo

@nurupo nurupo commented Sep 1, 2018

Copy link
Copy Markdown
Member

This change is Reviewable

@CLAassistant

CLAassistant commented Sep 1, 2018

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nurupo nurupo force-pushed the travis-freebsd-poweroff-fix branch from 04cc288 to b826009 Compare September 1, 2018 03:10
@codecov

codecov Bot commented Sep 1, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1145 into master will decrease coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1145     +/-   ##
========================================
- Coverage    82.9%   82.4%   -0.5%     
========================================
  Files          82      82             
  Lines       14473   14473             
========================================
- Hits        12002   11938     -64     
- Misses       2471    2535     +64
Impacted Files Coverage Δ
auto_tests/network_test.c 90.3% <0%> (-9.7%) ⬇️
toxav/msi.c 63.6% <0%> (-3.1%) ⬇️
toxcore/TCP_client.c 64.3% <0%> (-2.8%) ⬇️
toxcore/TCP_server.c 75% <0%> (-2.8%) ⬇️
toxav/toxav.c 67.2% <0%> (-1.7%) ⬇️
toxcore/group.c 71.7% <0%> (-1.5%) ⬇️
toxcore/LAN_discovery.c 83.9% <0%> (-1%) ⬇️
toxcore/net_crypto.c 92.8% <0%> (-0.8%) ⬇️
toxcore/onion_client.c 94.4% <0%> (-0.7%) ⬇️
toxcore/Messenger.c 85.8% <0%> (-0.2%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9764285...1a6e8b9. Read the comment docs.

@nurupo nurupo force-pushed the travis-freebsd-poweroff-fix branch from fc12b92 to 5a699e4 Compare September 1, 2018 09:24
@nurupo nurupo changed the title [WIP] Yet another FreeBSD fixing PR Fix login issue on Travis-CI FreeBSD build Sep 1, 2018
@nurupo nurupo requested a review from iphydf September 1, 2018 09:27
@nurupo

nurupo commented Sep 1, 2018

Copy link
Copy Markdown
Member Author

We change shells from whatever FreeBSD uses to bash, but we didn't change what shell prompt we expect (apparently bash and that other shell have different prompt), so that's why the build was getting stuck on wait_for "root@.*:~" before. Changing that to wait_for "root@.* ~" (the : is removed) fixes it.

Comment thread .travis/cmake-freebsd-stage1 Outdated
@nurupo nurupo force-pushed the travis-freebsd-poweroff-fix branch from 5a699e4 to e4d6209 Compare September 1, 2018 10:31
@nurupo nurupo force-pushed the travis-freebsd-poweroff-fix branch from e4d6209 to 1a6e8b9 Compare September 1, 2018 10:35
@nurupo

nurupo commented Sep 1, 2018

Copy link
Copy Markdown
Member Author

Feel free to merge.

@iphydf iphydf merged commit 1a6e8b9 into TokTok:master Sep 2, 2018
@iphydf iphydf added this to the v0.2.x milestone Sep 8, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants