Always use the passed logger (from Messenger) in msi_kill.#1153
Conversation
|
Aren't they the same logger anyway or do we actually have multiple logger instances per a toxcore+toxav instance? |
|
Oh, is this because |
|
Looking at that function, it assumes that |
|
This is a generally better way, we should really not have the logger be a member of so many structs. Any of them could be initialised incorrectly or not at all. This pr is mainly to narrow down the possible error space of the linked issue. |
|
Sounds good. |
Narrowing down #1149.
This change is