Skip to content

Assert that we don't kill tox before killing toxav.#1154

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:dont-kill-tox-before-toxav
Sep 10, 2018
Merged

Assert that we don't kill tox before killing toxav.#1154
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:dont-kill-tox-before-toxav

Conversation

@iphydf

@iphydf iphydf commented Sep 9, 2018

Copy link
Copy Markdown
Member

Possibly this is what's happening in #1149.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 9, 2018

@sudden6 sudden6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

@zoff I don't think it would be a good design if the destructor of an object can fail without it being a programmer error.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf force-pushed the dont-kill-tox-before-toxav branch from 536aac1 to 9f1757e Compare September 10, 2018 18:51
@codecov

codecov Bot commented Sep 10, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1154 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1154     +/-   ##
========================================
+ Coverage    82.7%   82.8%   +<.1%     
========================================
  Files          82      82             
  Lines       14667   14668      +1     
========================================
+ Hits        12141   12146      +5     
+ Misses       2526    2522      -4
Impacted Files Coverage Δ
toxcore/tox.c 65.8% <100%> (ø) ⬆️
auto_tests/toxav_many_test.c 92.5% <0%> (-4.1%) ⬇️
toxcore/LAN_discovery.c 83% <0%> (-1.9%) ⬇️
toxav/toxav.c 68.5% <0%> (+0.3%) ⬆️
toxcore/onion_client.c 95.9% <0%> (+0.6%) ⬆️
toxav/msi.c 66.2% <0%> (+1.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c2f51...9f1757e. Read the comment docs.

@iphydf iphydf merged commit 9f1757e into TokTok:master Sep 10, 2018
@iphydf iphydf deleted the dont-kill-tox-before-toxav branch September 10, 2018 19:19
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants