Assert that we don't kill tox before killing toxav.#1154
Merged
Conversation
sudden6
approved these changes
Sep 10, 2018
sudden6
left a comment
There was a problem hiding this comment.
@zoff I don't think it would be a good design if the destructor of an object can fail without it being a programmer error.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
Possibly this is what's happening in TokTok#1149.
536aac1 to
9f1757e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1154 +/- ##
========================================
+ Coverage 82.7% 82.8% +<.1%
========================================
Files 82 82
Lines 14667 14668 +1
========================================
+ Hits 12141 12146 +5
+ Misses 2526 2522 -4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly this is what's happening in #1149.
This change is