Skip to content

Fix using uninitialized mutex on call end#1195

Merged
iphydf merged 1 commit intoTokTok:masterfrom
sphaerophoria:issue-1194
Sep 21, 2018
Merged

Fix using uninitialized mutex on call end#1195
iphydf merged 1 commit intoTokTok:masterfrom
sphaerophoria:issue-1194

Conversation

@sphaerophoria
Copy link
Copy Markdown

@sphaerophoria sphaerophoria commented Sep 21, 2018

Closes #1194


This change is Reviewable

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 21, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

Comment thread toxav/toxav.c Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (...) {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@sphaerophoria sphaerophoria force-pushed the issue-1194 branch 2 times, most recently from 9edc7b9 to a9496f3 Compare September 21, 2018 20:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 21, 2018

Codecov Report

Merging #1195 into master will increase coverage by 0.3%.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1195     +/-   ##
========================================
+ Coverage    82.9%   83.2%   +0.3%     
========================================
  Files          82      82             
  Lines       14641   14646      +5     
========================================
+ Hits        12151   12200     +49     
+ Misses       2490    2446     -44
Impacted Files Coverage Δ
toxav/toxav.c 69.5% <25%> (+0.7%) ⬆️
toxcore/net_crypto.c 94.3% <0%> (-0.1%) ⬇️
toxcore/onion_client.c 95.9% <0%> (ø) ⬆️
toxcore/Messenger.c 86.7% <0%> (ø) ⬆️
toxcore/group.c 76.4% <0%> (+0.3%) ⬆️
auto_tests/network_test.c 100% <0%> (+2.4%) ⬆️
toxcore/TCP_server.c 77.7% <0%> (+2.7%) ⬆️
toxcore/TCP_client.c 67.1% <0%> (+2.7%) ⬆️
toxav/msi.c 68.4% <0%> (+3.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43b2ea...dc0b2e7. Read the comment docs.

@iphydf iphydf merged commit dc0b2e7 into TokTok:master Sep 21, 2018
@iphydf iphydf added this to the v0.2.x milestone Sep 21, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Cancelling unanswered toxav call locks uninitialied mutex

4 participants