Skip to content

Run UBSAN (undefined behaviour sanitizer) on Circle CI. - #1196

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:ubsan
Sep 22, 2018
Merged

iphydf merged 1 commit into
TokTok:masterfrom
iphydf:ubsan

Conversation

@iphydf

@iphydf iphydf commented Sep 21, 2018

Copy link
Copy Markdown
Member

This runs in the same build as asan, so "asan" now stands for both asan
and ubsan.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 21, 2018

@zoff99 zoff99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

This runs in the same build as asan, so "asan" now stands for both asan
and ubsan.
@codecov

codecov Bot commented Sep 22, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1196 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1196     +/-   ##
========================================
+ Coverage    82.7%   82.9%   +0.2%     
========================================
  Files          82      82             
  Lines       14646   14646             
========================================
+ Hits        12119   12154     +35     
+ Misses       2527    2492     -35
Impacted Files Coverage Δ
toxcore/onion_client.c 95.8% <0%> (-0.2%) ⬇️
toxcore/Messenger.c 86.5% <0%> (-0.1%) ⬇️
toxcore/net_crypto.c 94.2% <0%> (+0.6%) ⬆️
toxcore/LAN_discovery.c 85.8% <0%> (+0.9%) ⬆️
toxav/toxav.c 69% <0%> (+1.9%) ⬆️
toxav/msi.c 66.7% <0%> (+3%) ⬆️
auto_tests/network_test.c 97.5% <0%> (+7.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87f871...9c7c924. Read the comment docs.

@iphydf
iphydf merged commit 9c7c924 into TokTok:master Sep 22, 2018
@iphydf
iphydf deleted the ubsan branch September 22, 2018 13:30
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants