Repository navigation
Reset onion search rate for a friend when we see evidence that they are online - #1202
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
========================================
+ Coverage 82.9% 83.1% +0.2%
========================================
Files 82 82
Lines 14646 14645 -1
========================================
+ Hits 12144 12176 +32
+ Misses 2502 2469 -33
Continue to review full report at Codecov.
|
This resets friend search rate in two circumstances where it should be reset: * When the friend gets a dhtpk packet to us; * When a friend connection to the friend goes down.
iphydf
approved these changes
Sep 24, 2018
iphydf
left a comment
Member
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
Member
|
@zugz can you move the PR title to the description (because it's an implementation detail) and make the title something that users reading the changelog will understand (something closer to what the current description says, i.e. the effect on the behaviour)? |
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine last_reported_announced with last_seen in Onion_Friend.
This resets friend search rate in two circumstances where it should be
reset:
This change is