Revert "Improve cmake build for MSVC."#1203
Merged
iphydf merged 1 commit intoTokTok:masterfrom Sep 24, 2018
Merged
Conversation
sphaerophoria
approved these changes
Sep 24, 2018
sphaerophoria
left a comment
sphaerophoria
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @sphaerophoria)
sphaerophoria
approved these changes
Sep 24, 2018
sphaerophoria
left a comment
sphaerophoria
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained
sphaerophoria
approved these changes
Sep 24, 2018
sphaerophoria
left a comment
sphaerophoria
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained
This reverts commit f87f871.
iphydf
force-pushed
the
revert-msvc-change
branch
from
ad01fce to
bfd288c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
========================================
+ Coverage 82.7% 82.9% +0.1%
========================================
Files 82 82
Lines 14645 14646 +1
========================================
+ Hits 12123 12146 +23
+ Misses 2522 2500 -22
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f87f871.
Fixes #1201.
This change is