Improve Windows compatibility of toxav code.#1209
Merged
Merged
Conversation
hugbubby
approved these changes
Oct 8, 2018
hugbubby
left a comment
hugbubby
left a comment
Member
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained
- unistd.h doesn't exist on MSVC. - `vpx_codec_iface_t` is already `const`, so adding `const` qualifiers is redundant and causes warnings on MSVC.
Codecov Report
@@ Coverage Diff @@
## master #1209 +/- ##
========================================
+ Coverage 82.7% 82.8% +<.1%
========================================
Files 82 82
Lines 14647 14645 -2
========================================
+ Hits 12120 12127 +7
+ Misses 2527 2518 -9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vpx_codec_iface_tis alreadyconst, so addingconstqualifiers isredundant and causes warnings on MSVC.
This change is