Skip to content

Ensure save data unchanged after save and load - #1215

Merged
iphydf merged 1 commit into
TokTok:masterfrom
zugz:saveInvariance
Oct 16, 2018
Merged

Ensure save data unchanged after save and load#1215
iphydf merged 1 commit into
TokTok:masterfrom
zugz:saveInvariance

Conversation

@zugz

@zugz zugz commented Sep 29, 2018

Copy link
Copy Markdown

This change is Reviewable

@codecov

codecov Bot commented Sep 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1215 into master will increase coverage by 0.1%.
The diff coverage is 98.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1215     +/-   ##
========================================
+ Coverage    82.9%     83%   +0.1%     
========================================
  Files          82      82             
  Lines       14647   14692     +45     
========================================
+ Hits        12146   12200     +54     
+ Misses       2501    2492      -9
Impacted Files Coverage Δ
toxcore/onion_client.c 96% <100%> (ø) ⬆️
toxcore/DHT.c 76.7% <100%> (+0.1%) ⬆️
toxcore/Messenger.c 87% <100%> (+0.4%) ⬆️
auto_tests/save_load_test.c 98% <97.9%> (-0.6%) ⬇️
auto_tests/network_test.c 90.3% <0%> (-9.7%) ⬇️
toxcore/friend_connection.c 93.4% <0%> (-1.5%) ⬇️
toxcore/net_crypto.c 93.5% <0%> (-0.9%) ⬇️
toxcore/group.c 76% <0%> (-0.4%) ⬇️
toxcore/TCP_client.c 64.3% <0%> (-0.4%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605dfe8...4dd86f1. Read the comment docs.

@zugz
zugz force-pushed the saveInvariance branch 5 times, most recently from d7dd0cf to ba976bb Compare September 30, 2018 07:14
@iphydf iphydf modified the milestones: v0.2.8, v0.2.x Oct 7, 2018
Comment thread auto_tests/save_load_test.c Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++i

Comment thread auto_tests/save_load_test.c Outdated
Comment thread toxcore/TCP_client.c Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase on master?

@zugz

zugz commented Oct 10, 2018 via email

Copy link
Copy Markdown
Author

Comment thread toxcore/DHT.c Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra () around function call.

Comment thread auto_tests/save_load_test.c Outdated
@iphydf
iphydf merged commit 4dd86f1 into TokTok:master Oct 16, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants