Skip to content

Add AUTOTEST option to CMakeLists.txt#1223

Merged
iphydf merged 1 commit into
TokTok:masterfrom
chron0:patch-1
Oct 7, 2018
Merged

Add AUTOTEST option to CMakeLists.txt#1223
iphydf merged 1 commit into
TokTok:masterfrom
chron0:patch-1

Conversation

@chron0

@chron0 chron0 commented Oct 6, 2018

Copy link
Copy Markdown

This change is Reviewable

@CLAassistant

CLAassistant commented Oct 6, 2018

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment thread CMakeLists.txt Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misc_tools is needed for other things than auto tests. Better add the condition to the existing if inside function(auto_test target).

Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add the condition inside the existing if?

@codecov

codecov Bot commented Oct 6, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1223 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1223     +/-   ##
========================================
- Coverage    82.9%   82.9%   -0.1%     
========================================
  Files          82      82             
  Lines       14647   14647             
========================================
- Hits        12152   12147      -5     
- Misses       2495    2500      +5
Impacted Files Coverage Δ
toxav/toxav.c 67.6% <0%> (-1.7%) ⬇️
toxav/msi.c 65.6% <0%> (-1.2%) ⬇️
toxcore/friend_connection.c 93.6% <0%> (-0.9%) ⬇️
toxcore/Messenger.c 86.5% <0%> (-0.2%) ⬇️
toxcore/DHT.c 76.6% <0%> (-0.1%) ⬇️
toxcore/group.c 76.4% <0%> (+0.3%) ⬆️
toxcore/net_crypto.c 94.6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f35a84...17a7bf3. Read the comment docs.

@iphydf

iphydf commented Oct 6, 2018

Copy link
Copy Markdown
Member

Can you update README.md with the new option?

@nurupo nurupo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread CMakeLists.txt Outdated
@iphydf
iphydf force-pushed the patch-1 branch 2 times, most recently from c17e1c6 to 1c4d9b6 Compare October 7, 2018 19:16
@iphydf iphydf changed the title Add AUTOTEST Option to CMakeList.txt Add AUTOTEST Option to CMakeLists.txt Oct 7, 2018
@iphydf iphydf modified the milestones: v0.2.8, v0.2.x Oct 7, 2018
@iphydf iphydf changed the title Add AUTOTEST Option to CMakeLists.txt Add AUTOTEST option to CMakeLists.txt Oct 7, 2018
@iphydf
iphydf merged commit 17a7bf3 into TokTok:master Oct 7, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants