Skip to content

Include CTest in CMakeLists.txt to get valgrind support.#1229

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:ctest
Oct 17, 2018
Merged

Include CTest in CMakeLists.txt to get valgrind support.#1229
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:ctest

Conversation

@iphydf

@iphydf iphydf commented Oct 8, 2018

Copy link
Copy Markdown
Member

We can now run ctest --output-on-failure -D ExperimentalMemCheck -j 50
to run valgrind on all tests.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Oct 8, 2018
@iphydf iphydf assigned robinlinden and unassigned zugz Oct 16, 2018

@robinlinden robinlinden left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

We can now run `ctest --output-on-failure -D ExperimentalMemCheck -j 50`
to run valgrind on all tests.
@codecov

codecov Bot commented Oct 17, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1229 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1229     +/-   ##
========================================
- Coverage    83.1%     83%   -0.1%     
========================================
  Files          82      82             
  Lines       14692   14647     -45     
========================================
- Hits        12210   12168     -42     
+ Misses       2482    2479      -3
Impacted Files Coverage Δ
toxcore/TCP_server.c 75.9% <0%> (-4.4%) ⬇️
toxcore/LAN_discovery.c 84.9% <0%> (-1%) ⬇️
toxcore/Messenger.c 86.5% <0%> (-0.5%) ⬇️
toxcore/DHT.c 76.7% <0%> (-0.1%) ⬇️
toxcore/onion_client.c 95.3% <0%> (-0.1%) ⬇️
auto_tests/save_load_test.c 98.6% <0%> (+0.5%) ⬆️
auto_tests/toxav_many_test.c 97.2% <0%> (+0.6%) ⬆️
toxav/toxav.c 69.2% <0%> (+0.9%) ⬆️
toxcore/friend_connection.c 94.5% <0%> (+1.1%) ⬆️
toxav/msi.c 67% <0%> (+1.9%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6dde3c...1eaa55d. Read the comment docs.

@iphydf iphydf merged commit 1eaa55d into TokTok:master Oct 17, 2018
@iphydf iphydf deleted the ctest branch October 17, 2018 23:18
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants