Add some hopefully helpful documentation to the functions in mono_time.h#1239
Merged
Conversation
(I found I couldn't remember whether get_mono_time returned unix time or not, and had to source-dive to find out. This should make that unnecessary next time!)
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
========================================
- Coverage 83.4% 83% -0.5%
========================================
Files 82 82
Lines 14685 14685
========================================
- Hits 12251 12192 -59
- Misses 2434 2493 +59
Continue to review full report at Codecov.
|
hugbubby
approved these changes
Nov 4, 2018
Member
hugbubby
left a comment
There was a problem hiding this comment.
adds comments
-0.5% code coverage
O.o
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I found I couldn't remember whether get_mono_time returned unix time or
not, and had to source-dive to find out. This should make that
unnecessary next time!)
This change is