Skip to content

Define tox_conference_id_size and tox_conference_uid_size#1277

Merged
iphydf merged 1 commit into
TokTok:masterfrom
zugz:defineConfIdSize
Jan 3, 2019
Merged

Define tox_conference_id_size and tox_conference_uid_size#1277
iphydf merged 1 commit into
TokTok:masterfrom
zugz:defineConfIdSize

Conversation

@zugz

@zugz zugz commented Dec 8, 2018

Copy link
Copy Markdown

Closes #1264


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jan 3, 2019

@iphydf iphydf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@codecov

codecov Bot commented Jan 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1277 into master will decrease coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1277     +/-   ##
========================================
- Coverage    83.5%   83.4%   -0.1%     
========================================
  Files          82      82             
  Lines       14867   14829     -38     
========================================
- Hits        12420   12375     -45     
- Misses       2447    2454      +7
Impacted Files Coverage Δ
toxcore/tox_api.c 61.2% <0%> (-2.7%) ⬇️
auto_tests/toxav_many_test.c 92.5% <0%> (-4.8%) ⬇️
toxav/audio.c 65.7% <0%> (-4.4%) ⬇️
toxav/msi.c 64.5% <0%> (-2.6%) ⬇️
auto_tests/toxav_basic_test.c 81.6% <0%> (-2%) ⬇️
toxcore/friend_connection.c 94.9% <0%> (-1.2%) ⬇️
toxav/toxav.c 67.6% <0%> (-1.2%) ⬇️
toxcore/LAN_discovery.c 83.9% <0%> (-1%) ⬇️
auto_tests/encryptsave_test.c 95% <0%> (-0.7%) ⬇️
toxcore/Messenger.c 86.9% <0%> (-0.1%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e532057...1ddc922. Read the comment docs.

@iphydf iphydf merged commit 1ddc922 into TokTok:master Jan 3, 2019
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants