Skip to content

Avoid sending group messages to a peer before we have its group number#1287

Merged
iphydf merged 1 commit into
TokTok:masterfrom
zugz:groupNumberOnlyOnline
Jan 8, 2019
Merged

Avoid sending group messages to a peer before we have its group number#1287
iphydf merged 1 commit into
TokTok:masterfrom
zugz:groupNumberOnlyOnline

Conversation

@zugz

@zugz zugz commented Jan 5, 2019

Copy link
Copy Markdown

Hopefully fixes #1285


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jan 6, 2019
@zugz zugz force-pushed the groupNumberOnlyOnline branch from b754748 to 86935be Compare January 7, 2019 00:12
@codecov

codecov Bot commented Jan 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1287 into master will increase coverage by 0.1%.
The diff coverage is 96.7%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1287     +/-   ##
========================================
+ Coverage      83%   83.2%   +0.1%     
========================================
  Files          82      82             
  Lines       14957   14960      +3     
========================================
+ Hits        12427   12447     +20     
+ Misses       2530    2513     -17
Impacted Files Coverage Δ
toxcore/group.c 78.8% <96.7%> (ø) ⬆️
toxcore/friend_connection.c 94.9% <0%> (-1.2%) ⬇️
toxcore/net_crypto.c 94.1% <0%> (-0.9%) ⬇️
toxcore/Messenger.c 87% <0%> (ø) ⬆️
toxcore/DHT.c 77.8% <0%> (ø) ⬆️
toxcore/onion_client.c 96% <0%> (+0.7%) ⬆️
toxcore/TCP_server.c 82.9% <0%> (+2.5%) ⬆️
toxcore/TCP_client.c 67.5% <0%> (+2.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc1223...86935be. Read the comment docs.

@iphydf iphydf modified the milestones: v0.2.x, v0.2.9 Jan 7, 2019
@anthonybilinski

anthonybilinski commented Jan 7, 2019

Copy link
Copy Markdown

As commented on #1285, this doesn't seem to fix the issue. Is there anything else meant by the ticket assign?

I won't be able to get back to the environment that I was repoing on, and can't repro locally. My original test was run incorrectly.

Fix seems likely to solve my issue, but I won't be able verify.

@iphydf iphydf merged commit 86935be into TokTok:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Persistent group titles get mixed up

3 participants