Skip to content

Enable auto tests under STRICT_ABI if static libs are available. - #1289

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:test-if-static-libs
Jan 6, 2019
Merged

Enable auto tests under STRICT_ABI if static libs are available.#1289
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:test-if-static-libs

Conversation

@iphydf

@iphydf iphydf commented Jan 6, 2019

Copy link
Copy Markdown
Member

STRICT_ABI only breaks linkage if static libraries are not available,
because then we try to link against shared libraries with hidden symbols.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jan 6, 2019
@iphydf iphydf assigned nurupo and unassigned nurupo Jan 6, 2019
STRICT_ABI only breaks linkage if static libraries are not available,
because then we try to link against shared libraries with hidden symbols.
@iphydf
iphydf force-pushed the test-if-static-libs branch from 06a5421 to e08f631 Compare January 6, 2019 19:28
@codecov

codecov Bot commented Jan 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1289 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1289     +/-   ##
========================================
- Coverage    83.1%     83%   -0.1%     
========================================
  Files          82      82             
  Lines       14928   14928             
========================================
- Hits        12413   12401     -12     
- Misses       2515    2527     +12
Impacted Files Coverage Δ
auto_tests/toxav_many_test.c 92.5% <0%> (-4.1%) ⬇️
toxav/msi.c 65% <0%> (-1.7%) ⬇️
toxcore/friend_connection.c 94.9% <0%> (-1.2%) ⬇️
toxav/toxav.c 67.3% <0%> (-0.9%) ⬇️
toxcore/Messenger.c 87% <0%> (ø) ⬆️
toxcore/DHT.c 77.8% <0%> (ø) ⬆️
toxcore/net_crypto.c 95.1% <0%> (+0.1%) ⬆️
toxcore/onion_client.c 96% <0%> (+0.6%) ⬆️
toxcore/LAN_discovery.c 83.9% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8b5c8...e08f631. Read the comment docs.

@iphydf
iphydf merged commit e08f631 into TokTok:master Jan 6, 2019
@iphydf
iphydf deleted the test-if-static-libs branch January 6, 2019 19:37
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants