Fix misaligned 4-byte access in trace logging.#1293
Merged
Conversation
sudden6
approved these changes
Jan 8, 2019
sudden6
left a comment
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
iphydf
force-pushed
the
fix-misaligned-access
branch
from
January 8, 2019 23:04
7eea3ea to
00f157b
Compare
This code is undefined behaviour as is, and breaks on various platforms requiring strict alignment (many microcontrollers).
iphydf
force-pushed
the
fix-misaligned-access
branch
from
January 10, 2019 19:37
00f157b to
3dd31b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is undefined behaviour as is, and breaks on various platforms
requiring strict alignment (many microcontrollers).
This change is