Skip to content

Add some const qualifiers#1296

Merged
zugz merged 1 commit into
TokTok:masterfrom
zugz:addConst
Jan 12, 2019
Merged

Add some const qualifiers#1296
zugz merged 1 commit into
TokTok:masterfrom
zugz:addConst

Conversation

@zugz

@zugz zugz commented Jan 12, 2019

Copy link
Copy Markdown

(Implementing suggestions of sudden6)


This change is Reviewable

@iphydf iphydf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, module one nit.

Comment thread toxcore/tox.c Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also change the (Tox *) to (const Tox *) for consistency.

@iphydf iphydf added this to the v0.2.x milestone Jan 12, 2019
@codecov

codecov Bot commented Jan 12, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1296 into master will decrease coverage by 0.2%.
The diff coverage is 67.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1296     +/-   ##
========================================
- Coverage    83.2%     83%   -0.3%     
========================================
  Files          82      82             
  Lines       14978   14962     -16     
========================================
- Hits        12469   12425     -44     
- Misses       2509    2537     +28
Impacted Files Coverage Δ
toxcore/tox.c 63.6% <67.4%> (ø) ⬆️
toxcore/group.c 78.8% <67.7%> (ø) ⬆️
toxav/msi.c 63.6% <0%> (-4.8%) ⬇️
toxcore/TCP_client.c 64.6% <0%> (-2.9%) ⬇️
toxcore/TCP_server.c 80.3% <0%> (-2.6%) ⬇️
toxav/toxav.c 66.6% <0%> (-2.5%) ⬇️
toxcore/Messenger.c 86.7% <0%> (-0.3%) ⬇️
toxcore/onion_client.c 96% <0%> (ø) ⬆️
toxcore/net_crypto.c 94.9% <0%> (+0.9%) ⬆️
auto_tests/toxav_many_test.c 96.6% <0%> (+4%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ff395...a4bca35. Read the comment docs.

(Implementing suggestions of sudden6)
@zugz zugz merged commit a4bca35 into TokTok:master Jan 12, 2019
@zugz zugz deleted the addConst branch January 12, 2019 22:24
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants