Skip to content

Specify that buffer size for tox_conference_peer_get_name is given by $size#1302

Merged
zugz merged 1 commit into
TokTok:masterfrom
zugz:apiNameBufferSizeFix
Jan 21, 2019
Merged

Specify that buffer size for tox_conference_peer_get_name is given by $size#1302
zugz merged 1 commit into
TokTok:masterfrom
zugz:apiNameBufferSizeFix

Conversation

@zugz

@zugz zugz commented Jan 21, 2019

Copy link
Copy Markdown

This change is Reviewable

@zugz zugz changed the title Specify that buffer length for tox_conference_peer_get_name given by size function Specify that buffer size for tox_conference_peer_get_name is given by $size Jan 21, 2019
@zugz zugz force-pushed the apiNameBufferSizeFix branch from d506208 to 0aad180 Compare January 21, 2019 21:21
@codecov

codecov Bot commented Jan 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1302 into master will decrease coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1302     +/-   ##
========================================
- Coverage    83.4%   82.9%   -0.5%     
========================================
  Files          82      82             
  Lines       14978   14978             
========================================
- Hits        12495   12423     -72     
- Misses       2483    2555     +72
Impacted Files Coverage Δ
toxcore/crypto_core_test.cc 90.3% <0%> (-9.7%) ⬇️
toxcore/TCP_client.c 64.6% <0%> (-2.9%) ⬇️
toxcore/LAN_discovery.c 83% <0%> (-2.9%) ⬇️
toxcore/TCP_server.c 80.3% <0%> (-2.6%) ⬇️
toxav/msi.c 64.2% <0%> (-2.6%) ⬇️
toxcore/net_crypto.c 93.6% <0%> (-1.8%) ⬇️
toxav/toxav.c 67.9% <0%> (-1.7%) ⬇️
toxcore/friend_connection.c 94.9% <0%> (-1.2%) ⬇️
toxcore/Messenger.c 86.8% <0%> (-0.2%) ⬇️
toxcore/onion_client.c 96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b754e...0aad180. Read the comment docs.

@zugz zugz merged commit 0aad180 into TokTok:master Jan 21, 2019
@zugz zugz deleted the apiNameBufferSizeFix branch January 21, 2019 22:14
@robinlinden robinlinden added this to the v0.2.10 milestone May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants