Do not send the same packet to the same node twice#1310
Do not send the same packet to the same node twice#1310robinlinden merged 1 commit intoTokTok:masterfrom
Conversation
|
@kurnevsky are you sure this is correct? |
|
@zoff99 I think yes, |
|
sorry did not see the inner loop. damn folding :-) line 2004 - 2007 does not do anything even now. thats the issue then i guess. alright |
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
e4c238a to
ec9dedf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1310 +/- ##
========================================
- Coverage 84.1% 82.9% -1.2%
========================================
Files 86 82 -4
Lines 15708 14975 -733
========================================
- Hits 13218 12429 -789
- Misses 2490 2546 +56
Continue to review full report at Codecov.
|
ec9dedf to
d26b11d
Compare
It's a bug introduced in c-toxcore after assocs refactoring. See the original code: https://github.com/irungentoo/toxcore/blob/bf69b54f64003d160d759068f4816b2d9b2e1e21/toxcore/DHT.c#L1740-L1763
This change is